kubernetes-sigs/cluster-api

Return CLC conversion warnings to user using warnings of validation webhook

Open

#8,944 opened on Jun 30, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (1,532 forks)auto 404
help wantedkind/featurepriority/backlogtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be added (User Story)?

As a user I would like to be informed while creating a cluster using Ignition that my configuration has warnings.

Detailed Description

As a follow up to #4279, now that we have warnings support in validation webhooks, we should make CLC conversion code added in https://github.com/kubernetes-sigs/cluster-api/pull/4172#discussion_r584669828 return warnings to the user.

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

Contributor guide

Research direction
Examine the existing CLC conversion code and the warning handling in validation webhooks. Modify the conversion function to include warnings in the webhook response, ensuring they are surfaced to the user.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetesCluster API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70