kubernetes/minikube

improve UI advice when user needs to delete the cluster

Open

#10,460 opened on Feb 12, 2021

View on GitHub
 (18 comments) (0 reactions) (2 assignees)Go (5,222 forks)batch import
good first issuekind/buglifecycle/frozenpriority/backlog

Repository metrics

Stars
 (31,799 stars)
PR merge metrics
 (Avg merge 12d 19h) (43 merged PRs in 30d)

Description

here we confuse the user with two things

❗ You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster. and

😿 Failed to start ssh bare metal machine. Running "minikube delete -p foo" may fix it: config: please provide an IP address

we should had sticked with first advice

drewpca(pts/0):~% minikube start -p foo --memory 6GB
😄  [foo] minikube v1.17.1 on Debian rodete
✨  Using the ssh driver based on existing profile
❗  You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster.
👍  Starting control plane node foo in cluster foo
🤦  StartHost failed, but will try again: config: please provide an IP address
😿  Failed to start ssh bare metal machine. Running "minikube delete -p foo" may fix it: config: please provide an IP address
 
❌  Exiting due to GUEST_PROVISION: Failed to start host: config: please provide an IP address
 
😿  If the above advice does not help, please let us know: 
👉  https://github.com/kubernetes/minikube/issues/new/choose

Contributor guide

Research direction
Find the source file(s) that output the warning messages about memory size change and the failed SSH start message. Modify the flow to show only the first advice when memory change is detected, and ensure the SSH error message is suppressed or changed to a more helpful hint.
Tech stack
go
Domain
backendcli
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90