kubernetes/minikube
View on GitHubMake the provisioner interface support more container runtimes
Open
#10,883 opened on Mar 19, 2021
co/generic-driverco/none-driverco/runtime/crioco/runtime/dockerhelp wantedkind/featurelifecycle/frozenpriority/backlog
Repository metrics
- Stars
- (31,799 stars)
- PR merge metrics
- (Avg merge 12d 19h) (43 merged PRs in 30d)
Description
Currently the libmachine interface is quite targetted towards Docker:
// Do the actual provisioning piece:
// 1. Set the hostname on the instance.
// 2. Install Docker if it is not present.
// 3. Configure the daemon to accept connections over TLS.
// 4. Copy the needed certificates to the server and local config dir.
// 5. Configure / activate swarm if applicable.
Provision(swarmOptions swarm.Options, authOptions auth.Options, engineOptions engine.Options) error
It needs to at least know which runtime to install, during provisioning ?
And the swarmOptions and engineOptions need a generic replacement...
Currently the provisioner in minikube is broken, in that it doesn't provision.
It just assumes that all container runtimes are always present on the node.
The original provisioner would install Docker, if it was not already available:
const (
DefaultEngineInstallURL = "https://get.docker.com"
)
func installDockerGeneric(p Provisioner, baseURL string) error {
// install docker - until cloudinit we use ubuntu everywhere so we
// just install it using the docker repos
if output, err := p.SSHCommand(fmt.Sprintf("if ! type docker; then curl -sSL %s | sh -; fi", baseURL)); err != nil {
return fmt.Errorf("error installing docker: %s", output)
}
return nil
}