kubernetes/minikube

Calling Docker daemon even for other container runtimes

Open

#8,577 opened on Jun 26, 2020

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Go (5,222 forks)batch import
co/runtime/containerdco/runtime/criohelp wantedkind/buglifecycle/frozenpriority/backlog

Repository metrics

Stars
 (31,799 stars)
PR merge metrics
 (Avg merge 12d 19h) (43 merged PRs in 30d)

Description

From https://github.com/kubernetes/minikube/issues/8554#issuecomment-650387112

Still have a lot of unconditional calls to Docker, around the code base:

DigestByDockerLib

ExistsImageInDaemon

LoadFromTarball

WriteImageToDaemon

Usually these fail since we stop dockerd, but should be conditionalized.

Contributor guide

Research direction
Identify all unconditional calls to Docker functions (DigestByDockerLib, ExistsImageInDaemon, LoadFromTarball, WriteImageToDaemon) and add runtime checks to conditionally execute them only when Docker is the active container runtime.
Tech stack
go
Domain
backenddevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60