lance-format/lance

working with pydantic model instances

Open

#1,106 opened on Jul 30, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (695 forks)github user discovery
A-pythonenhancementgood first issue

Repository metrics

Stars
 (6,582 stars)
PR merge metrics
 (Avg merge 6d 1h) (219 merged PRs in 30d)

Description

  1. Currently we still require an explicit call to pydantic_to_schema when creating a table. Instead, we can create a LanceTable.from_pydantic_model() method that infers both the name and the schema. For the name we'll convert to snake_case automatically.

  2. To add pydantic model instances, currently we require the user to explicitly convert to a dictionary. Instead, we could just automatically do it under the hood.

Contributor guide

Research direction
Examine the existing `pydantic to schema` function and the table creation workflow. Then implement `LanceTable.from pydantic model()` to infer name and schema automatically, and modify the insert method to accept pydantic model instances directly by converting them to dicts under the hood.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonpydanticGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65