lance-format/lance

Support `regexp_match` for `LargeUtf8`

Open

#904 opened on May 25, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (695 forks)github user discovery
A-pythongood first issuehelp wantedrust

Repository metrics

Stars
 (6,582 stars)
PR merge metrics
 (Avg merge 6d 1h) (219 merged PRs in 30d)

Description

#899 enabled regexp_match, but if we call with regexp_match(col, pattern) where col is of type LargeUtf8 the code panics.

a few notes:

  1. regexp_match on LargeUtf8 is probably highly inefficient, as the datasize practically doubles in memory (compare to Utf8)
  2. I'm not sure how to dispatch to arrow_cast function in datafusion expressions.

Contributor guide

Research direction
Investigate how arrow cast is used for Utf8 in regexp match and extend support to LargeUtf8. Consider performance implications and potential casting or direct implementation.
Tech stack
rust
Domain
database
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40