lbryio/lbry-desktop

Cover images are forced into 16:9 ratio by cropping the image

Open

#2,322 opened on Mar 11, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (412 forks)batch import
area: designarea: viewercsshacktoberfestneeds: explorationtype: improvement

Repository metrics

Stars
 (3,596 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The Issue

Cover images are forced into 16:9 ratio by cropping the image sometimes making it unrecognizable

Steps to Reproduce

Place a cover image that isnt 16:9

  1. 2. 3.

Expected Behavior

Tell us what should happen. The app should display the entire image and fill in the unused space with certain colors

Actual Behavior

Tell us what happens instead. It crops the image forcing it into a 16:9 ratio BBBBBBBBBBBBB

Suggested Solutions

Tell us your suggested solutions if you have any. To make the display like the image I linked AAAAAAAAAAAAA

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.