libp2p/py-libp2p

Complete all Notify interface methods

Open

#137 opened on Mar 15, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (238 forks)auto 404
help wanted

Repository metrics

Stars
 (618 stars)
PR merge metrics
 (PR metrics pending)

Description

The following interface methods in Notify have not been implemented as they are not crucial to PubSub PoC.

  • disconnected
  • closed_stream
  • listen_close

They should be implemented in swarm.py however this will not be possible before #136 lands.

Contributor guide

Research direction
Examine the Notify interface definition and the existing implemented methods to understand the expected behavior, then implement the 'disconnected', 'closed stream', and 'listen close' methods in swarm.py, taking into account dependencies on PR #136.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonasyncio
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65