libp2p/py-libp2p

Medley of `pubsub` improvements

Open

#283 opened on Sep 5, 2019

View on GitHub
 (6 comments) (1 reaction) (0 assignees)Python (238 forks)auto 404
help wanted

Repository metrics

Stars
 (618 stars)
PR merge metrics
 (PR metrics pending)

Description

Leaving this here while I'm reviewing the current pubsub packages...

  1. Don't serialize message sends, eg: https://github.com/libp2p/py-libp2p/blob/master/libp2p/pubsub/gossipsub.py#L172-L177 Happens here and in floodsub as well -- this is a great place to use asyncio.gather

  2. "separate policy from mechanism" -- in the same place, we defer to the particular router to decide who to send new msgs to... and then do the sending in the router itself. as far as i can tell, we can pull out the sending part into the Pubsub class, relying on the router for what should be its only job -- determining peers for some action

Contributor guide

Research direction
Examine the serial message sending in pubsub classes and refactor to use asyncio.gather for concurrency. Then separate peer selection (router) from message sending (Pubsub).
Tech stack
python
Domain
backendnetworking
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonasyncio
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60