litmuschaos/litmus

Chore: remove inefficient code

Open

#4,206 opened on Oct 4, 2023

View on GitHub
 (6 comments) (0 reactions) (1 assignee)HTML (574 forks)batch import
Hacktoberfestgood first issue

Repository metrics

Stars
 (3,702 stars)
PR merge metrics
 (Avg merge 42d 14h) (20 merged PRs in 30d)

Description

As you can see in the switch expression, lastExperimentRunStatus === ExperimentRunStatus.RUNNING and lastExperimentRunStatus === ExperimentRunStatus.QUEUED are always true. IMO, we can shift these statements to true

Anyone who finds good first issues or participates in hacktoberfest can take this issue.

https://github.com/litmuschaos/litmus/blob/794676f6b75e08835334fd5d675e0b0d096d5f9d/chaoscenter/web/src/views/ExperimentDashboardV2/ExperimentDashboardV2Table.tsx#L207-L223

Contributor guide

Research direction
Open the file chaoscenter/web/src/views/ExperimentDashboardV2/ExperimentDashboardV2Table.tsx. Locate lines 207-223 in the switch expression. Replace the conditions `lastExperimentRunStatus === ExperimentRunStatus.RUNNING` and `lastExperimentRunStatus === ExperimentRunStatus.QUEUED` with `true` because they are always true. Remove any unnecessary else or default cases if applicable.
Tech stack
typescriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85