litmuschaos/litmus

"Re-Download the manifest" generates SERVER_ADDR without a scheme

Open

#5,105 opened on Apr 22, 2025

View on GitHub
 (1 comment) (0 reactions) (1 assignee)HTML (574 forks)batch import
Hacktoberfestbughacktoberfest-accepted

Repository metrics

Stars
 (3,702 stars)
PR merge metrics
 (Avg merge 42d 14h) (20 merged PRs in 30d)

Description

What happened:

"Re-Download the manifest" generates SERVER_ADDR without a scheme

What you expected to happen:

I expect the redownloaded manifest will be equivalent to the downloaded manifest (Chaos Infrastructures). However, SERVER_ADDR is different and doesn't have a scheme ("my_domain.dev" instead of "https://my_domain.dev", for example).

Where can this issue be corrected? (optional)

https://github.com/litmuschaos/litmus/blob/master/chaoscenter/graphql/server/graph/chaos_infrastructure.resolvers.go#L219

it's very likely that it needs to look like this:

https://github.com/litmuschaos/litmus/blob/master/chaoscenter/graphql/server/pkg/chaos_infrastructure/service.go#L208

How to reproduce it (as minimally and precisely as possible):

  1. Add infrastructure and download the manifest.

  2. Click "Re-download the manifest" at Infrastructure page.

Anything else we need to know?:

Due to this error, the subscriber cannot establish a WebSocket connection when I use a re-downloaded manifest. This occurs because I use an ingress and require a secure scheme (as described in the values). However, when the SERVER_ADDR lacks the scheme specification, the subscriber defaults to an insecure connection (ws instead of wss), causing the connection to fail.

As a result, while the initially downloaded manifest works without problems, the problem arises when I re-download the configuration.

Contributor guide