livepeer/go-livepeer

Run golangci-lint on all packages

Open

#1,801 opened on Mar 18, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (223 forks)auto 404
area: CIgood first issuetype: tech debt

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

We currently only run golangci-lint on certain packages in CI. We should run golangci-lint locally, fix all the warnings/errors and then start running golangci-lint on all packages in CI. The one thing to consider here is which linters should be enabled by default (or just use the default linters used by golangci-lint).

Contributor guide

Research direction
Run golangci lint locally on all packages, fix all warnings and errors, then update the CI workflow file to run golangci lint on all packages instead of only specific ones.
Tech stack
go
Domain
build systemdevops
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gogolangci lint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70