livepeer/go-livepeer

livepeer_bench: back-slashes in the file path don't work

Open

#1,844 opened on Apr 15, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (223 forks)auto 404
good first issuehacktoberfesttype: bug

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Back-slashes in the input manifest's path cause the benchmarking to fail on Windows.

To Reproduce Here's the original Discord message from a user reporting this problem.

Expected behavior Back-slashes should work out-of-the-box on Windows, or alternatives (like using forward-slashes) should be better documented.

Screenshots image

Desktop (please complete the following information):

  • OS: Windows

Additional context Golang's path library does not work well with back-slashes We can try using an alternate library when creating the segment path from the input manifest's directory: https://github.com/livepeer/go-livepeer/blob/3908252d23edd62590c61b02598c5fffc148014b/cmd/livepeer_bench/livepeer_bench.go#L106

Contributor guide

Research direction
Investigate the path handling in cmd/livepeer bench/livepeer bench.go line 106 and replace path.Join with filepath.Join or use a cross platform path library.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70