livepeer/go-livepeer

Livepeer should identify itself in `user-agent` HTTP header

Open

#836 opened on Apr 22, 2019

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Go (223 forks)auto 404
good first issuestatus: iceboxtype: feature

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Currently, outgoing HTTP requests (at least from the webhook) have a generic go library as its header. I'm getting:

'user-agent': 'Go-http-client/1.1',

For a variety of reasons, we should identify ourselves — we already have the version baked into the binary, so we should just be livepeer/${version}.

Contributor guide

Research direction
Find where outgoing HTTP requests are made (e.g., webhook client) and set the 'User Agent' header to 'livepeer/' + version constant.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90