luanti-org/luanti

override.txt doesn't work in "server" texture pack

Open

#10,773 opened on Jan 3, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (2,395 forks)auto 404
@ Client / AudiovisualsBugTexturesgood first issue

Repository metrics

Stars
 (13,341 stars)
PR merge metrics
 (PR metrics pending)

Description

Minetest version
5.3.0 and 5.4.0-dev-af22dd86e
OS / Hardware

Operating system: Windows 10 64-bit CPU: Intel Core 2 Duo

Summary

The override.txt file doesn't work when it's in the "server" texture pack, even when the same file works when used in a client texture pack.

This error is output to the log when trying to use it:

2021-01-03 17:12:29: INFO[Main]: Server: ignoring unsupported file extension: "override.txt"
Steps to reproduce
  1. Create a "server" folder in the textures folder.
  2. Create a override.txt inside that folder with the following contents:
default:dirt_with_grass top default_stone.png
  1. Load into a world, and the textures for default:dirt_with_grass will not have changed.
  2. Quit, and then enable the "server" texture pack in the content tab.
  3. Load into a world again, and default:dirt_with_grass will now have the stone texture on top.

Contributor guide

Research direction
Investigate the file loading logic for server texture packs and identify why override.txt is being rejected as an unsupported file extension.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65