luanti-org/luanti

`minetest.disconnect_player` frames reason text as an error message

Open

#14,986 opened on Aug 16, 2024

View on GitHub
 (7 comments) (2 reactions) (0 assignees)C++ (2,395 forks)auto 404
@ Client / AudiovisualsBugUI/UXgood first issue

Repository metrics

Stars
 (13,341 stars)
PR merge metrics
 (PR metrics pending)

Description

Minetest version

5.9.0

Summary

If you get disconnected via minetest.disconnect_player(player, "Some reason text."), Minetest disconnects you but the message is framed as an error message. It looks something like this:

"An error has occured: Access denied. Reason: Some reason text.".

I think this is wrong; the message should not be framed as an error but as a generic message. Specifically, the "An error has occured:" must go.

This is because disconnecting a player like this is normal and not done because there's an error or bug in the software.

Steps to reproduce

  1. Install luacmd
  2. Do the command: /lua minetest.disconnect_player(me, "This is the disconnect reason text.")

Contributor guide

Research direction
Locate the code that formats disconnect messages in the Minetest engine. Specifically, find where 'An error has occurred: Access denied. Reason: ...' is generated and modify it to remove the error framing.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70