luckyframework/avram

Polymorphic preloads don't work the same as other ones

Open

#1,035 opened on May 8, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Crystal (67 forks)auto 404
bughacktoberfest

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/luckyframework/avram/blob/bc2ad7b2da0093bb8e81a2de66e0c16057eea740/src/avram/polymorphic.cr#L160-L163

Normal preloads allow you to pass a block, or override the BaseQuery, but the polymorphic preloads are missing those overloads

https://github.com/luckyframework/avram/blob/bc2ad7b2da0093bb8e81a2de66e0c16057eea740/src/avram/associations/has_many.cr#L170

Contributor guide

Research direction
Inspect the polymorphic preload implementation at the linked lines and compare with the non polymorphic preload overloads to add missing block and query override support.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCrystal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70