luckyframework/avram

Operation callbacks are missing the conditional arguments

Open

#1,066 opened on Sep 25, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Crystal (67 forks)auto 404
hacktoberfest

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/luckyframework/avram/blob/bb63db88513b05e80030a4c61c9ef48b0ea12dbe/src/avram/callbacks.cr#L97C9-L97C19

With SaveOperation and DeleteOperation you can do before_save :do_thing, if: :valid?, but this doesn't work for before_run or after_run

Contributor guide

Research direction
Review the callback implementation in Avram to understand how conditional arguments are passed to before save and before run/after run callbacks. Check the code at the referenced line and trace how the if: option is handled for different callback types.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65