luckyframework/avram

Adding ensure UTC default to DB with config option

Open

#732 opened on Sep 23, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Crystal (67 forks)auto 404
feature requesthacktoberfest

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

When you create a new DB, postgres seems to set the timezone to the host machine by default. This could lead to some odd behavior, especially in development, where your local DB is in PST, but your production DB is in UTC.

Postgres allows you to set this timezone at the session, DB, and global levels. What we could do is add some SQL to set this when you first create your DB:

execute <<-SQL
alter database #{Avram::Migrator::Runner.db_name} set time zone '#{Avram.settings.default_timezone}';
SQL

By default we could have a habitat setting default_timezone that's UTC. Then if you wanted to change this, you could. If you inherit a DB, then this would never affect you since you'd never run the create task.

Contributor guide

Research direction
Add a habitat setting `default timezone` with default 'UTC', then modify the create database task to execute an ALTER DATABASE SET timezone statement using that value.
Tech stack
sqlpostgresql
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75