luckyframework/lucky_cli

CSRF should be removed if it's disabled in forms

Open

#696 opened on Nov 5, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (49 forks)auto 404
good first issue

Repository metrics

Stars
 (92 stars)
PR merge metrics
 (PR metrics pending)

Description

You have the option to disable CSRF in forms with https://github.com/luckyframework/lucky/blob/60b24a8f0489d6115063d15ba5974481b02c9abe/src/lucky/tags/form_helpers.cr#L3

If this is disabled, then we should probably also display the metatags as well.

https://github.com/luckyframework/lucky_cli/blob/522c046f6cc3306c416a5c5175d589d5fd8bc682/src/browser_app_skeleton/src/components/shared/layout_head.cr#L11

Contributor guide

Research direction
Check the form helper where CSRF can be disabled and the layout head component where CSRF metatags are rendered. Ensure that when CSRF is disabled, the metatags are not generated.
Tech stack
None
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75