mapbox/mapbox-gl-directions

Port localGeocoder option from mapbox-gl-geocoder

Open

#166 opened on Feb 6, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (253 stars)
PR merge metrics
 (PR metrics pending)

Description

It looks like the directions control is not recognizing the localGeocoder option from the mapbox-gl-geocoder. The map renders fine, but it doesn't respond to any local data passed to it.

map.addControl(new MapboxDirections({ accessToken: mapboxgl.accessToken, geocoder: {localGeocoder: coordinatesGeocoder} }), 'top-left');

Contributor guide

Research direction
Examine how the geocoder options are passed and consumed in the MapboxDirections constructor. Check if localGeocoder is properly forwarded to the geocoder.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptMapbox GL JS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40