matcornic/hugo-theme-learn

Check perfect-scrollbar is used correctly

Open

#258 opened on Apr 1, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (1,427 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

( cc @ozobi )

There are two static JS files relating to perfect scrollbar

./static/js/perfect-scrollbar.min.js
./static/js/perfect-scrollbar.jquery.min.js

Are these duplicated files or do they serve different purposes? Additionally, I can't see the instantiation of the library anywhere

Looking for any mention of new PerfectScrollbar.

Can either the duplicate file get removed, or can we remove it completely if it's unused?

Contributor guide

Research direction
Search for 'PerfectScrollbar' or 'new PerfectScrollbar' in the theme's JS files. Compare the two static files for differences. Determine if either is used by examining the theme's layout templates and JavaScript initialization code.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75