matomo-org/matomo-icons

Unify name of placeholder icon and use proper icon instead of empty png.

Open

#11 opened on May 10, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (16 forks)github user discovery
Hacktoberfestfile structure

Repository metrics

Stars
 (29 stars)
PR merge metrics
 (Avg merge 3h 55m) (2 merged PRs in 30d)

Description

At the moment the placeholder icon (Transparent png) has multiple different names, which is bugging me for some time.

placeholder_icon_filenames = {
    "brand": "unk.png",
    "browsers": "UNK.png",
    "devices": "unknown.png",
    "os": "UNK.png",
    "searchEngines": "xx.png",
    "socials": "xx.png"
}

It would be nice to rename them to one common name (e.g. unk.png).

This also needs to be changed in Piwik (functions for generating icon path and in tests) and in the ReferrersManager-Plugin (see https://github.com/sgiehl/piwik-plugin-ReferrersManager/pull/11)

Contributor guide

Research direction
Find all occurrences of the placeholder icon filenames (unk.png, UNK.png, unknown.png, xx.png) across the codebase and in the referenced plugin, then replace them with a single consistent name like 'unk.png', updating function calls and tests accordingly.
Tech stack
python
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70