microsoft/Forge

Make RetryExhaustedOnAction and TimeoutOnAction strings accessible from Tree

Open

#26 opened on Aug 20, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (59 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (331 stars)
PR merge metrics
 (PR metrics pending)

Description

Instead of hard-coding "RetryExhaustedOnAction" and "TimeoutOnAction", let's add public const strings or enums so they are more accessible. They should be accessible through the tree/schema so users can easily check the ActionResponse.Status.

Possible solution is to add a new class to the parameters of the Roslyn script.

"ShouldSelect": "C#|(await Session.GetLastActionResponseAsync()).Status == FooEnums.TimeoutOnAction",

Contributor guide

Research direction
Find where "RetryExhaustedOnAction" and "TimeoutOnAction" strings are hard coded in the codebase. Consider adding a new class or enum in the parameters of the Roslyn script so they are accessible through the tree/schema.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80