microsoft/PowerShellForGitHub

Update New-GitHubRepositoryBranchProtectionRule parameters to match those of New-GitHubRepositoryBranchPatternProtectionRule

Open

#320 opened on Mar 23, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PowerShell (189 forks)auto 404
good first issuehelp wantedtechnical debtup for grabs

Repository metrics

Stars
 (635 stars)
PR merge metrics
 (PR metrics pending)

Description

Feature Idea Summary

During #313, New-GitHubRepositoryBranchPatternProtectionRule was added which has a similar parameter set to New-GitHubRepositoryBranchProtectionRule, however it uses the singular case for parameter names per the [ strongly encouraged development guidelines for PowerShell] (https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/strongly-encouraged-development-guidelines?view=powershell-7.1#use-singular-parameter-names).

We should update the parameter names of New-GitHubRepositoryBranchPatternProtectionRule to match.

Feature Idea Additional Details

See this PR comment thread for more context.

Requested Assignment

I'm just suggesting this idea, but don't want to implement it.

Operating System

OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-bit
WindowsVersion       : 2004
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.610
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.610
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Module Version

Running: 0.16.0
Installed:

Contributor guide