microsoft/onnxscript

informing about bad positional argument in node constructor

Open

#1,984 opened on Dec 26, 2024

View on GitHub
 (2 comments) (1 reaction) (1 assignee)Python (117 forks)auto 404
contribution welcomegood first issue

Repository metrics

Stars
 (445 stars)
PR merge metrics
 (PR metrics pending)

Description

rewr.txt

When you mistakingly do

  def lr_pattern( op, x ):
      return op.LeakyRelu( x, 1.0)

instead of

  def lr_pattern_good( op, x ):
      return op.LeakyRelu( x, alpha=1.0)

You will get such error text:

AttributeError: 'float' object has no attribute '_add_usage'

Expected behavior: something like

TypeError: LeakyRelu() takes 2 positional arguments but 3 were given

Possible patch: missed_keyword.patch

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.