microsoft/retina

edge cases for MetricConfiguration CRD

Open

#74 opened on Mar 19, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Go (293 forks)auto 404
good first issuetype/fix

Repository metrics

Stars
 (3,161 stars)
PR merge metrics
 (PR metrics pending)

Description

If enableAnnotations=false, then advanced metrics won't show up unless a MetricConfiguration CRD exists (metric modules are initialized via metricModule's Reconcile()). We should initialize with default context options instead.

Also, should we support MetricConfiguration CRD when enableAnnotations=true? Right now, we do not: https://github.com/microsoft/retina/blob/9248f0d140e5c93da77bdbdf5e43ea3b0029cfd4/controller/main.go#L254-L268

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.