microsoft/vscode-languageserver-node

UTF-8 support

Open

#1,224 opened on Apr 5, 2023

View on GitHub
 (4 comments) (13 reactions) (0 assignees)TypeScript (397 forks)auto 404
feature-requesthelp wanted

Repository metrics

Stars
 (1,776 stars)
PR merge metrics
 (PR metrics pending)

Description

For about half a year now, UTF-8 character positioning support has been supported by the LSP protocol since 3.17.0 and multiple servers, such as clangd and rust-analyzer, have supported it either since then or before then (in fact, clangd "invented" this capability with an LSP extension).

This feature would be highly useful in this client library. For my server (and probably many others), UTF-8 is much simpler to handle, already supported by the LSP interface library (lsp-types in my case), and of course supported by many IDEs. Only the glue code client shim doesn't cooperate yet.

Reopens #748 in a new issue, since the author of that issue and the maintainers of this repo have not done so.

Contributor guide

Research direction
Explore how the LSP client and server currently handle position encoding (likely UTF 16). Familiarize yourself with the LSP 3.17 specification on PositionEncodingKind and the client/server capability negotiation. Look for existing tests and implementations in the repository that deal with text document positions and offsets, and consider how to add support for UTF 8 encoding without breaking backward compatibility.
Tech stack
typescriptnodejs
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40