microsoft/vscode-languageserver-node

Allow initializationOptions, fillInitializeParams, etc to be async

Open

#1,283 opened on Aug 3, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (397 forks)auto 404
feature-requesthelp wanted

Repository metrics

Stars
 (1,776 stars)
PR merge metrics
 (PR metrics pending)

Description

I want to do some async work to compute the initialization options and client capabilities.

Since BaseLanguageClient#initialize is already async, I'd like to make these calls also async:

https://github.com/microsoft/vscode-languageserver-node/blob/f2ff7d55464a1f58f978cb6635bd8865f050553c/client/src/common/client.ts#L1227-L1228

https://github.com/microsoft/vscode-languageserver-node/blob/f2ff7d55464a1f58f978cb6635bd8865f050553c/client/src/common/client.ts#L1232

Contributor guide

Research direction
Investigate how the client currently sets initializationOptions and fillInitializeParams in client.ts (around lines 1227-1232), understand the async flow of the initialize method, and explore ways to allow these callbacks to be async, such as using Promise.all or changing method signatures to return promises.
Tech stack
typescriptnodejs
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptNode.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75