microsoft/vscode-languageserver-node

Overflow value(exceeding uinteger) passed into jsonrpc but still work

Open

#1,574 opened on Oct 18, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (397 forks)auto 404
feature-requesthelp wanted

Repository metrics

Stars
 (1,776 stars)
PR merge metrics
 (PR metrics pending)

Description

The reason is that I found that the fmt feature of my lsp server cannot be used in IntelliJ, but it still work in vscode. After investigation, I found that I assigned a u32:Max to formatResponse.textedit.range.line in the format's Response I implemented the lsp server in rust, and u32 was used as the range type in rust's lsp-type, but the range of this value in lsp should be 0-2^31 -1. I think this is the cause of the problem

But I'm not sure whether vscode has special handling for this situation or just forgot to check

https://github.com/redhat-developer/lsp4ij/issues/579 https://github.com/kcl-lang/kcl/pull/1698

Contributor guide

Research direction
Investigate how JSON RPC parameters are validated in this library, and add explicit checks for text position fields to ensure they are within the LSP specified range (0 to 2^31-1). Look for existing validation in the protocol types and add tests to cover the overflow case.
Tech stack
typescriptnodejs
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65