microsoft/vscode-languageserver-node

Reference codeLens action not working

Open

#495 opened on Jun 6, 2019

View on GitHub
 (12 comments) (0 reactions) (0 assignees)TypeScript (397 forks)auto 404
feature-requestgood first issuehelp wanted

Repository metrics

Stars
 (1,776 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm trying to use the build in command for editor.action.showReferences and have it bound to a codeLens. But I can't figure out, what I'm doing wrong.

[Trace - 12:51:43 AM] Received response 'codeLens/resolve - (25)' in 6ms.
Result: {
    "range": {
        "start": {
            "line": 380,
            "character": 8
        },
        "end": {
            "line": 381,
            "character": 50
        }
    },
    "data": {
        "codeLensType": "referenceCounter",
        "references": [
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 380,
                        "character": 8
                    },
                    "end": {
                        "line": 380,
                        "character": 16
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 117,
                        "character": 30
                    },
                    "end": {
                        "line": 117,
                        "character": 38
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 152,
                        "character": 35
                    },
                    "end": {
                        "line": 152,
                        "character": 43
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 157,
                        "character": 35
                    },
                    "end": {
                        "line": 157,
                        "character": 43
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 350,
                        "character": 35
                    },
                    "end": {
                        "line": 350,
                        "character": 43
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 363,
                        "character": 33
                    },
                    "end": {
                        "line": 363,
                        "character": 41
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 385,
                        "character": 25
                    },
                    "end": {
                        "line": 385,
                        "character": 33
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 388,
                        "character": 23
                    },
                    "end": {
                        "line": 388,
                        "character": 31
                    }
                }
            },
            {
                "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "range": {
                    "start": {
                        "line": 479,
                        "character": 16
                    },
                    "end": {
                        "line": 479,
                        "character": 24
                    }
                }
            }
        ],
        "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm"
    },
    "command": {
        "title": "9 references",
        "command": "editor.action.showReferences",
        "arguments": [
            {
                "$mid": 1,
                "path": "/home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                "scheme": "file"
            },
            {
                "line": 380,
                "character": 8
            },
            [
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 380,
                            "character": 8
                        },
                        "end": {
                            "line": 380,
                            "character": 16
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 117,
                            "character": 30
                        },
                        "end": {
                            "line": 117,
                            "character": 38
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 152,
                            "character": 35
                        },
                        "end": {
                            "line": 152,
                            "character": 43
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 157,
                            "character": 35
                        },
                        "end": {
                            "line": 157,
                            "character": 43
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 350,
                            "character": 35
                        },
                        "end": {
                            "line": 350,
                            "character": 43
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 363,
                            "character": 33
                        },
                        "end": {
                            "line": 363,
                            "character": 41
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 385,
                            "character": 25
                        },
                        "end": {
                            "line": 385,
                            "character": 33
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 388,
                            "character": 23
                        },
                        "end": {
                            "line": 388,
                            "character": 31
                        }
                    }
                },
                {
                    "uri": "file:///home/razze/Development/elm-spa-example/src/Page/Article/Editor.elm",
                    "range": {
                        "start": {
                            "line": 479,
                            "character": 16
                        },
                        "end": {
                            "line": 479,
                            "character": 24
                        }
                    }
                }
            ]
        ]
    }
}

This is the error that happens, when I click the code action. Screenshot from 2019-06-07 00-50-26

https://github.com/microsoft/vscode-languageserver-node/issues/210

https://github.com/elm-tooling/elm-language-server/blob/57550c1a0c95b74df3ecb71c98b261785a306c69/src/providers/codeLensProvider.ts#L79

Contributor guide

Research direction
Investigate the codeLens resolve handling in the vscode languageserver node library, specifically how command arguments are serialized and passed to the client. Compare the output with the expected format for editor.action.showReferences. Check related issue #210 and any existing codeLens tests.
Tech stack
typescriptnodejs
Domain
backendapitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitTypeScriptLSP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35