mikepenz/Android-Iconics

Compose Image clips edges of some icons

Open

#648 opened on Jul 24, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (613 forks)batch import
help wanted

Repository metrics

Stars
 (5,277 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

About this issue

While working with the library I noticed some of my icons were being clipped/cropped at the edges. Through some experimentation I got it working by setting respectFontBounds to false and paddingDP to 0. I assume this isn't intentional/expected though.

I have created a small sample project using the crown icon from FontAwesome demonstrating the behaviour using Compose vs Views vs Compose with respectFontBounds set to false.

I had a quick dig around in IconicsPainter and the pathBounds are larger than the viewBounds, setting respectFontBounds impacts the textSize instead of the pathBounds though.

https://github.com/crowleysimon/IconicsClipDemo

Details

  • [x] Used library version - Tested with 5.40 and 5.5.0-b01
  • [x] Other used libraries, potential conflicting libraries - used only the core compose libraries

Checklist

Contributor guide

Research direction
Investigate the relationship between pathBounds and viewBounds in IconicsPainter, and how respectFontBounds affects textSize. Check if the clipping is caused by the path bounds exceeding view bounds, and consider adjusting the drawing logic to account for icon padding or scaling.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinAndroidJetpack Compose
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70