mumble-voip/mumble

Settings window should be non-modal, and the "Apply" button should apply settings immediately

Open

#2,734 opened on Jan 17, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (1,062 forks)batch import
feature-requesthelp wantedui

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

Hi I am on the latest v1.3 snapshot (64bit) and it appears that the apply button does not work as it should.

Simple steps to reproduce:

  1. Open Preferences
  2. Go to User Interface and change the "layout"
  3. Press apply

The new layout will not be applied until restart. However pressing "OK" works as it should and applies the setting correctly.

Contributor guide

Research direction
Inspect the Apply button event handler and trace the code path to understand why it does not apply settings immediately, unlike the OK button. Focus on the difference in handling between Apply and OK actions.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65