mumble-voip/mumble

Improve error message for invalid channel name

Open

#3,993 opened on Mar 13, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (1,062 forks)batch import
feature-requestgood first issueserver

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

Context We had a bunch of users that have been confused as to why they can't name their channels in a certain way. This is because from the error message it isn't clear what names would be allowed and that this is a server setting that can be tweaked.

Describe the feature you have in mind We should enhance the error message to include the RegEx that is currently set for the server when stating that the name is invalid. And potentially we also want to include a hint that this is a setting of the server and nothing hard-coded.

Contributor guide

Research direction
Locate the error message for invalid channel names in the server code, retrieve the regex pattern used for validation, and modify the message to include the regex and a note that it's a server setting.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Regular Expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60