neos/neos-development-collection

Get rid of NodeTypeConfigurationEnrichmentAspect

Open

#2,867 opened on Jan 17, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (248 forks)auto 404
!!! Next majorI: Discussion‌‌help wanted

Repository metrics

Stars
 (267 stars)
PR merge metrics
 (PR metrics pending)

Description

The NodeTypeConfigurationEnrichmentAspect hooks into the NodeType::__construct and post-processes the node type configuration in three steps:

  • addEditorDefaultsToNodeTypeConfiguration
  • addLabelsToNodeTypeConfiguration
  • mapIconNames

Using AOP for this seems needlessly complex and hard to debug. Furthermore it's no longer possible to adjust this behavior.

I would suggest to create three NodeTypePostprocessors as a replacement for the AOP aspect.

Contributor guide

Research direction
Study the existing AOP aspect implementation and the NodeTypePostprocessorInterface to create three postprocessors for addEditorDefaults, addLabels, and mapIconNames. Replace the aspect registration in the dependency injection configuration.
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75