nextcloud/text

Failing preview generation results in 404 istead of original image

Open

#6,755 opened on Dec 8, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (125 forks)auto 404
1. to developbuggood first issuephp

Repository metrics

Stars
 (644 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug We had some traces in Sentry:

Image

Image

Since we don't catch these they will be caught on the Controller Level which then sends a 404. We should return the raw image instead. In case of the trace here it was a png and could have been served fine.

Server details: cloud.nextcloud.com from 30.0.1.1 to 30.0.2.2 - probably longer.

Contributor guide

Research direction
Inspect the preview generation code and controller error handling to catch exceptions and return the original image instead of a 404.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75