nytimes/library

Generalize youtube embeds to support more content

Open

#220 opened on Sep 16, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (148 forks)auto 404
enhancementgood first issuegood for learningneeds more context

Repository metrics

Stars
 (1,180 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem Description

From this https://github.com/nytimes/library/issues/67, it seems like we can embed youtube videos. I would like to be able to embed other content as well. For example, we would like to embed:

  1. Google Drive Videos
  2. Google slides / sheets
  3. Other platforms (for example, our company uses cloudapp for internal video sharing)

Feature

Could we have config settings that allow users to set domains / URL patterns? This way we can decide what type of links we want to parse and how they would be embedded.

We might want to have some embed syntax to avoid automatically embedding everything.

I could try to take a stab at this feature if this is something you think Library should support. It seems like since we already support youtube it would be in scope?

Contributor guide

Research direction
Review the existing embed implementation for YouTube. Understand how URLs are parsed and iframes generated. Explore how to add a configuration option for custom URL patterns. Consider using a plugin system or a regex list.
Tech stack
javascript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70