nytimes/library

Audit script load locations, inline code

Open

#53 opened on Aug 11, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (148 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,180 stars)
PR merge metrics
 (PR metrics pending)

Description

As Isaac said in #51, we could likely move many (if not all) of our script tags out of the document <head>.

It looks like all the other Library scripts are in the head (and we just haven't audited this in a while). [...] I think it would be worthwhile for us to be consistent about where scripts are included. [...] What do you think about moving the other includes so they can all be together? My hunch is that this wouldn't break anything but would be curious to see what you find.

Originally posted by @isaacwhite in https://github.com/nytimes/library/pull/51

Additionally, as seen in #283, our inline client-side code could probably use some cleanup as well.

Contributor guide

Research direction
Audit the current script load locations in the HTML files, identify which can be moved out of <head>, and propose a consistent placement. Also review inline code for cleanup opportunities.
Tech stack
javascript
Domain
frontenddocumentation
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitHTMLJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75