open-telemetry/opentelemetry-collector

[cmd/mdatagen] Add an option to generate setters from callbacks

Open

#10,901 opened on Jul 18, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (2,146 forks)auto 404
cmd/mdatagenenhancementhelp wanted

Repository metrics

Stars
 (7,237 stars)
PR merge metrics
 (PR metrics pending)

Description

Component(s)

No response

Is your feature request related to a problem? Please describe.

To avoid doing unnecessary work fetching data from external sources for disabled metrics or resource attributes. Originally posted by @mx-psi in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24360#discussion_r1266593277

Describe the solution you'd like

The control of how to generate the setter can be set in metadata.yaml similar to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/apachereceiver/metadata.yaml#L66

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Research direction
Examine the referenced pull request discussion (#24360) and the metadata.yaml example in the apachereceiver to understand the current setter generation mechanism. Implement a new option in metadata.yaml to control setter generation from callbacks, modifying the mdatagen code generation logic accordingly.
Tech stack
go
Domain
backenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60