openfoodfacts/openfoodfacts-server

Really remove pictures when deleted by admins/moderators

Open

#6,240 opened on Jan 4, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Perl (236 forks)batch import
good first issue⏰ Stale🖼️ Images

Repository metrics

Stars
 (477 stars)
PR merge metrics
 (Avg merge 15d 21h) (157 merged PRs in 30d)

Description

What

  • When an admin deletes an image, it's removed from the list of pictures in the product's page, but it's not removed from the filesystem nor from static serving.

Proposed solution

  • The photo should be completely removed from static serving and the filesystem.

Additional context

  • As an example, 44 photos were deleted on May 2022 (source: moderators private group). Without counting other deleted photos for some other reasons.

Part of

  • #5525

Contributor guide

Research direction
Investigate the existing image deletion logic in the Perl backend; find where the file removal is missing and add filesystem deletion after the database record is removed.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Perlfilesystem operations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65