openfoodfacts/openfoodfacts-server

Do not compare products to categories that are not taxonomized

Open

#6,853 opened on Jun 3, 2022

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Perl (236 forks)batch import
good first issue⏰ Stale🔀 Product alternatives🤳🥫 blocking mobile apps🤳🥫 mobile apps

Repository metrics

Stars
 (477 stars)
PR merge metrics
 (Avg merge 15d 21h) (157 merged PRs in 30d)

Description

Describe the bug

  • From https://github.com/openfoodfacts/smooth-app/issues/2147 : there are 25 products that have the "vegan" category, which does not exist in the taxonomy (we want this info in the labels). But that results in those products being compared to the other 24 products (in the nutrition facts table, and in the Compare button of Smoothie), which does not really make sense.

To Reproduce

Expected behavior

  • Ignore non taxonomized categories for comparisons.

Part of

  • #8919

Contributor guide

Research direction
Locate the code that compares products based on categories and add a condition to skip categories that are not present in the taxonomy.
Tech stack
perl
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Perl
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60