openfoodfacts/openfoodfacts-server

Move inline JavaScript code out of `import_photos_upload.pl`

Open

#7,343 opened on Sep 15, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Perl (236 forks)batch import
HacktoberfestTemplate::Toolkitgood first issue⏰ Stale

Repository metrics

Stars
 (477 stars)
PR merge metrics
 (Avg merge 15d 21h) (157 merged PRs in 30d)

Description

In cgi/import_photos_upload.pl from line 212. There is some inline JS that shouldn't be there. This JavaScript code should ideally be in a new file templates/import_photos_upload.tt.js. an example for refactoring JS out of perl script linked here

Contributor guide

Research direction
Look at the linked example PR (https://github.com/openfoodfacts/openfoodfacts server/pull/5283/files) to understand the pattern for extracting inline JS from Perl into .tt.js files. Then identify the inline JS in cgi/import photos upload.pl around line 212 and move it to a new file templates/import photos upload.tt.js, adjusting any references accordingly.
Tech stack
javascript
Domain
backendfull stack
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPerlJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80