openmaptiles/openmaptiles-tools

`download-osm -make-dc` to use a `.poly` file for BBOX

Open

#253 opened on May 14, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (147 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (463 stars)
PR merge metrics
 (PR metrics pending)

Description

The BBOX created by download-osm -make-dc using pbf-based statistics is larger that the bounding box of the polygon used to create the extract. In a relatively small area the bbox was 18-20 times larger.

Geofabrik - 18x

Source West South East North Area
Polygon 34.079 29.377 35.915 33.351 7.296
PBF statistics 25.149 22.000 36.900 33.484 134.943

OpenStreetMap.fr - 20x

Source West South East North Area
Polygon 34.050 29.435 35.915 33.355 7.311
PBF statistics 25.149 22.000 36.900 34.686 149.073

It would be nice if make-dc will use the bounding box of the extraction polygon by default, and use the statistics-based bounding box only if it cannot be found. Currently poligon files are available from Geofabrik.de, OpenStreetMap.fr, and bbbike.org

Contributor guide

Research direction
Examine the source code in openmaptiles tools that calculates the BBOX from PBF statistics. Implement a fallback to read the .poly file and compute its bounding box when the .poly file is available.
Tech stack
python
Domain
clidevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70