opensearch-project/reporting

Use dashboards settings in report configurations

Open

#41 opened on May 13, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Kotlin (87 forks)auto 404
enhancementfeature requestgood first issue

Repository metrics

Stars
 (33 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Plugins Please list all plugins currently enabled.

Screenshots If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

Currently, the time_range component uses a constant from report_settings_constants.tsx to feed the commonlyUsedRanges property of EuiSuperDatePicker inside it.

This is not the default behavior across Kibana. The default behavior is to load this from uiSettings service, allowing the user to override the available options.

I'm proposing this change that is not a breaking change but a "fix" that makes this plugin follow the default behavior across Kibana.

This issue was originally submitted by @iget-master https://github.com/opendistro-for-elasticsearch/kibana-reports/issues/351

Contributor guide

Research direction
Research how to use the uiSettings service in OpenSearch Dashboards plugins to replace the hardcoded constant with a user configurable setting. Look for examples in other Kibana plugins that use uiSettings to feed commonlyUsedRanges to EuiSuperDatePicker.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70