openzfs/zfs

Warning about deduplication is not accurate

Open

#2,829 opened on Oct 24, 2014

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C (1,703 forks)batch import
Type: Documentationgood first issue

Repository metrics

Stars
 (9,908 stars)
PR merge metrics
 (Avg merge 5d 21h) (62 merged PRs in 30d)

Description

The warning introduced by 971808ec9f62bc3f8e0347ebace6a19429d4e61d about data duplication is not accurate. I did a write-up about why the rule of thumb provided is not accurate:

https://news.ycombinator.com/item?id=8437921

@FransUrbo I do not really want to have people spreading FUD quote the man page when I try to explain how things actually work. This message should be amended for accuracy.

Contributor guide

Research direction
Locate the warning message introduced in commit 971808ec9f62bc3f8e0347ebace6a19429d4e61d, understand the deduplication logic, and propose a more accurate warning based on the discussion in the issue and referenced HN comment.
Tech stack
c
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65