openzipkin/zipkin-js

Adds support for http.route based name

Open

#183 opened on Jan 30, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (167 forks)auto 404
help wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently http middlewares use the http method for naming spans. This solution is a not so bad low cardinality option, however from user perspective this could be improved by using the path instead of the verb. For that we can override the span name in the onPreResponse (see this in hapi for example) event so instead of having get as span name we get get /user/{user_id}.

Ping @fbaiodias @adriancole

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.