openzipkin/zipkin-js

Status code 1xx should not be marked as error

Open

#343 opened on Mar 11, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (167 forks)auto 404
good first issue

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, responses with status code <200 are being marked as errors.

https://github.com/openzipkin/zipkin-js/blob/master/packages/zipkin/src/instrumentation/httpServer.js#L91 https://github.com/openzipkin/zipkin-js/blob/master/packages/zipkin/src/instrumentation/httpClient.js#L43

Comes from https://github.com/openzipkin/brave/issues/874

Ping @adriancole @ghermeto

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.