openzipkin/zipkin-js

http tests should cover the client originated trace use case

Open

#346 opened on Mar 26, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (167 forks)auto 404
good first issuehelp wantedtechdebt

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

@thegryfon noticed that in community axios implementations, some leak contexts and you wouldn't necessarily know until a second root trace is attempted.

here's an example scenario I think tests could cover:

there is no parent trace in scope create a client request create a second client request verify that both client requests are root spans

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.