openzipkin/zipkin-js

Refactor request-promise

Open

#397 opened on Jul 7, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (167 forks)auto 404
help wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

After this #176 merged, there have been changes in request-promise NPM site says the following:

Also check out the new libraries that are very similar to request-promise v4: request-promise-native v1 – Does not depend on Bluebird and uses native ES6 promises instead. request-promise-any v1 – Allows you to register any Promise library supported by any-promise.

It also says this...

Continuation Local Storage is no longer supported. However, you can get back the support by using request-promise-any.

We should see if we can eliminate our custom promise type sitting in request-promise considering the above. I know there is other work pending merge which can help, just didn't want to lost track

cc @mkante

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.