openzipkin/zipkin-js

Errors thrown by zipkin bubbles all the way to the top

Open

#424 opened on Jul 25, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (167 forks)auto 404
help wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

When using zipkin-instrumentation-restify, an error that was being thrown in zipkin bubbled up all the way to the top, and out of the middleware, which causes the server to crash.

The error should be handled gracefully and not cause errors to be thrown out of the middleware.

This issue was also raised in #422 (direct quote link)

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.